Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove edmCheckMultithreading from hltIntegrationTests #42993

Merged
merged 1 commit into from
Oct 16, 2023
Merged

remove edmCheckMultithreading from hltIntegrationTests #42993

merged 1 commit into from
Oct 16, 2023

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 11, 2023

PR description:

As pointed out in #42988 (comment) this is no longer needed, as the Framework doesn't support Legacy module types as of CMSSW_13_0_0_pre3.
This should alleviate the pressure on CERN HTCondor batch nodes in which HLT IBs tests are run, for a more thorough description see #42988 (comment).

PR validation:

Run an integration test from a recent HLT integration ticket CMSHLT-2957

 hltIntegrationTests /users/ddesouza/HI2023/Add_ZDC_Assym/HLT/V1 -n 800 --mc -d output_hltIntegTestPbPb_upc -x "--globaltag auto:phase1_2023_realistic_hi" -x "--eras Run3 --l1-emulator uGT" -x "--l1 L1Menu_CollisionsHeavyIons2023_v1_1_4_xml" -i file:/eos/cms/store/group/phys_heavyions/anstahll/CERN/Run3/2023/MC/STARLIGHT/CohJPsi_STARLIGHT_5p36TeV_2023Run3_RAW_20230812/CohJPsi_STARLIGHT_5p36TeV_2023Run3/CohJPsi_STARLIGHT_5p36TeV_2023Run3_RAW_20230812/230812_063634/0000/step2_STARlight_Digi_10.root -x "--no-output --open --paths HLT_HIUPC*nAsymXOR*" >& test.txt &

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but will be backported to at least 13.2.X in which there is active HLT development.

@mmusich
remove edmCheckMultithreading from hltIntegrationTests
5ba1130 
- this is no longer needed, as the Framework doesn't support Legacy module types as of CMSSW_13_0_0_pre3
@mmusich mmusich mentioned this pull request Oct 11, 2023
Merged
@cmsbuild cmsbuild added this to the CMSSW_13_3_X milestone Oct 11, 2023
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42993/37166

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @missirol, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato, @missirol this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Oct 11, 2023

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-200950/35140/summary.html
COMMIT: 5ba1130
CMSSW: CMSSW_13_3_X_2023-10-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42993/35140/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 7 lines from the logs
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3356920
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3356886
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Oct 12, 2023

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar
Copy link
Contributor

@mmusich , should we backport this to 13.1 and 13.0 too?

@mmusich
Copy link
Contributor Author

mmusich commented Oct 12, 2023

should we backport this to 13.1 and 13.0 too?

we don't have active development in these cycles, so from the hlt point of view it's not useful. If you think it's useful for core I can do that as well.

@smuzaffar
Copy link
Contributor

We are building IBs and running HLT tests for those release cycles too. So it will help to reduce the unnecessary memory load on build nodes

This was referenced Oct 12, 2023
Merged
Merged
@mmusich
Copy link
Contributor Author

mmusich commented Oct 12, 2023

We are building IBs and running HLT tests for those release cycles too. So it will help to reduce the unnecessary memory load on build nodes

@smuzaffar there you go:

@mmusich
Copy link
Contributor Author

mmusich commented Oct 13, 2023

is there anything preventing the merge of this PR @cms-sw/orp-l2 kind ping.

@mmusich
Copy link
Contributor Author

mmusich commented Oct 14, 2023

@cms-sw/orp-l2 let me renew the plea for merging this PR, we've been experiencing delays in the HLT IB tests that this PR is suppsed to mitigate (see #42988)

@Martin-Grunewald
Copy link
Contributor

urgent

  • to fix problems in IB tests

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3931d6c into cms-sw:master Oct 16, 2023
@mmusich mmusich deleted the remove_edmCheckMultithreading_13_3_X branch October 16, 2023 10:09
@cmsbuild cmsbuild mentioned this pull request Oct 16, 2023
Closed
@mmusich mmusich mentioned this pull request Oct 17, 2023
Closed
@cmsbuild cmsbuild mentioned this pull request Oct 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved fully-signed hlt-approved orp-approved tests-approved urgent
Projects
None yet
Milestone
CMSSW_13_3_X
Development

Successfully merging this pull request may close these issues.
5 participants
@mmusich @cmsbuild @smuzaffar @Martin-Grunewald @antoniovilela